Fix registering on conference #1220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Quentinchampenois
requested review from
Stef-Rousset,
BarbaraOliveira13 and
a team
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| module Decidim | |||
| module Conferences | |||
| describe ConferencesController do | |||
| describe RegistrationTypesControllerController do | |||
There was a problem hiding this comment.
Suggested change
| describe RegistrationTypesControllerController do | |
| describe ConferencesController do |
No need to change the described class
| let!(:registration_types) do | ||
| create_list(:registration_type, registration_types_count, conference:) | ||
| end | ||
| let(:registration_type) { registration_types.first } |
There was a problem hiding this comment.
Unused variable registration_type
| end | ||
|
|
||
| context "when registration_types is empty" do | ||
| let(:registration_types) { nil } |
There was a problem hiding this comment.
Suggested change
| let(:registration_types) { nil } | |
| let(:registration_types) { [] } |
…1221) * fix: hide register button in conference when no registration types * lint: add missing space in conference show view page
Conference registering change requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)