Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleted users follow #1225

Closed
wants to merge 8 commits into from
Closed

Conversation

Stef-Rousset
Copy link

@Stef-Rousset Stef-Rousset commented May 21, 2024

🎩 What? Why?

When a private user of a non transparent private assembly (or a private participatory process) is deleted, the follows of assembly or its components are also deleted

📌 Related Issues

Link your PR to an issue

  • Fixes issue 12851

Testing

  1. As an admin, edit an assembly and make it private and non transparent (in the Visibility tab)
  2. If there is no meeting, add a meeting component to it
  3. Invite "user@example.org" as a private user of this assembly
  4. As a user, access to the private assembly and click on the follow button
  5. Go to the meeting inside assembly and follow it
  6. As an admin, delete the private user "user@example.org"
  7. As a user, check that you can’t access to the private assembly anymore
  8. As an admin, add again "user@example.org" as a private user
  9. As a user, go to the assembly and see that your follow has been deleted
  10. As a user, go to the meeting and see that your follow has also been deleted

♥️ Thank you!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@Stef-Rousset Stef-Rousset marked this pull request as ready for review May 21, 2024 15:06
@Stef-Rousset Stef-Rousset changed the title Fix/deleted users follow fix/deleted users follow May 23, 2024
@Stef-Rousset Stef-Rousset changed the title fix/deleted users follow fix deleted users follow May 23, 2024
@Stef-Rousset Stef-Rousset changed the title fix deleted users follow Fix deleted users follow May 23, 2024
Copy link

@BarbaraOliveira13 BarbaraOliveira13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it locally and it works 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants