Image Testing 2.0 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… store the tests locally instead
# Conflicts: # OpenSpaceVisualTesting/testRun.py
| "difference-thumbnail", "log" | ||
| ] as const; | ||
|
|
||
| const p: any = req.params; |
There was a problem hiding this comment.
This should probably specify a type rather than any e.g., define
type Parameters = {
type: string;
group: string;
name: string;
hardware: string;
timestamp: string || Date || number // or w/e type this is
}
There was a problem hiding this comment.
I tried but its gets really wordy to have any proper type information in here. Since the type would have to be of typeof types and then the req.params would have to be properly parsed which would result in worse error messages.
But if there is a better way for this, I'd be happy to see and have it
|
|
||
|
|
||
|
|
||
| # TODO: Retry openspace api connection until it works |
There was a problem hiding this comment.
I'm thinking if this is something we should do in the API directly and then have an optional parameter in connect to specify retries ?
There was a problem hiding this comment.
Yea, that'd be great
ylvaselling
approved these changes
May 21, 2024
Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an iteration of the previously existing image testing server. Instead of generated the webpage as the tests are finished, the application is now split up into two parts.
The backend server hosts a webpage (https://regression.openspaceproject.com) that receives candidate images and will run the image testing against a known-good reference image. If a test is new, the first submission will be the reference image, but the reference image can also be updated through the user interface.
The runner Python script can run on a multitude of machines, run tests against OpenSpace and then submit them to the backend for display.
For more information see the README.md file