-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Notifier - Extending integration options and flow related notifications #42
Conversation
Samer, there are a few questions related to these changes that I wanted to confirm with you:
|
Thanks for submitting the PR and accompanying information! I looked over it and it all looks good. To answer your questions:
I am going to await your feedback on the unit/site name and about importing a config with InfluxDB data before I merge this in but otherwise looks great, thanks again! |
Samer, thanks for the feedback on all of this. I have introduced the necessary import/export routines to cover the new settings options. I have used a minor version bump of Firmware to identify whether the importing Controller can support the new options. I have also aligned on Site Name as the identifier used in notifications. The code in App that manages this setting assumes that the "master" reference is held in browser storage rather than sourced from Firmware which is a bit different to all the other settings. I have continued with this design pattern and look to ensure Firmware is kept in sync with any changes. I trigger Firmware sync (i.e. sendToOS call) in the newLoad() routine once App has confirmed Controller is connected and we can determine if the Site Name needs updating. Appreciate your thoughts on this. I have yet to hear back from Ray so appreciate if we hold off any merge till I get a steer on the Firmware side of things. Thanks again for the support. |
Thank you for your changes! I will wait until I hear from you regarding the firmware changes to merge this PR however it all looks good! Thank you again! |
98192e8
to
23b7659
Compare
Closing as Firmware PR is stale. |
This PR (and the associated PR for Firmware) addresses three objectives with OpenSprinkler:
During the process of implementing the above, the following have also been included:
In order to implement the above, the PRs have made a number of significant changes to both Firmware and App that require review:
In the commits below, I have provided more detail/questions on the specific changes. Appreciate your feedback and happy to take any modifications on-board.