Add web config localization lables #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add localization lables in InputMacroAddonPage and PinMapping - add Chinese translation that added in PR#1078 - remove unused lables
mizma
reviewed
Jul 4, 2024
| 'input-macro-3-header-text': 'マクロ 3 設定', | ||
| 'input-macro-4-header-text': 'マクロ 4 設定', | ||
| 'input-macro-5-header-text': 'マクロ 5 設定', | ||
| 'input-macro-6-header-text': 'マクロ 6 設定', |
There was a problem hiding this comment.
if you could add 'input-macro-macro-list-txt': 'マクロ {{macroNumber}} 設定' there that would be nice. although I would have to work on some of your new additions so I could do it at that time. either is fine I guess.
There was a problem hiding this comment.
sure, anything else?
There was a problem hiding this comment.
no I'll work on the other new labels once this is merged.
arntsonl
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added these localization lables by imitating those previous PRs. Compiled and tested by myself, looks good to me.