Fixed spelling and grammar on all doc pages #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheTrainGoes
previously approved these changes
Apr 18, 2023
README.md
Outdated
| @@ -29,17 +29,17 @@ Input latency is tested using the methodology outlined at [WydD's inputlag.scien | |||
|
|
|||
| | Version | Mode | Poll Rate | Min | Max | Avg | Stdev | % on time | %1f skip | %2f skip | | |||
| | - | - | - | - | - | - | - | - | - | - | | |||
| | v0.3.1 | All | 1 ms | 0.56 ms | 1.32 ms | 0.85 ms | 0.24 ms | 95.95% | 4.05% | 0% | | |||
| | v0.4.3 | All | 1 ms | 0.46 ms | 1.24 ms | 0.77 ms | 0.24 ms | 96.37% | 3.63% | 0% | | |||
There was a problem hiding this comment.
@FeralAI could we get numbers for v0.6.3 added here?
There was a problem hiding this comment.
These are the numbers from my latest test with XInput (should be pretty much same for all modes) on a fresh device with v0.6.3:
| polling interval | 1.0 |
|---|---|
| min | 0.46 |
| max | 1.64 |
| average | 0.89 |
| stddev | 0.29 |
| % no skip | 95.59% |
| % skip 1 frame | 4.41% |
| % skip 2 frames | 0% |
| % skip 3 frames | 0% |
| @@ -29,17 +29,17 @@ Input latency is tested using the methodology outlined at [WydD's inputlag.scien | |||
|
|
|||
| | Version | Mode | Poll Rate | Min | Max | Avg | Stdev | % on time | %1f skip | %2f skip | | |||
| | - | - | - | - | - | - | - | - | - | - | | |||
| | v0.3.1 | All | 1 ms | 0.56 ms | 1.32 ms | 0.85 ms | 0.24 ms | 95.95% | 4.05% | 0% | | |||
| | v0.4.3 | All | 1 ms | 0.46 ms | 1.24 ms | 0.77 ms | 0.24 ms | 96.37% | 3.63% | 0% | | |||
|
|
|||
| Full results can be found in the [GP2040-CE Firmware Latency Test Results](https://docs.google.com/spreadsheets/d/1eeX0SCOYnUDZMYzt_69wDpjnB_XUtvsfvHJYxxgTj28/edit#gid=1559471406) Google Sheet. | |||
TheTrainGoes
approved these changes
Apr 18, 2023
henrebotha
pushed a commit
to henrebotha/GP2040-CE-1
that referenced
this pull request
May 3, 2023
* 0.4.3 latency, spelling, grammar, descriptions * Updated wording * Update README.md * Update README.md * Update faq.md * Update usage.md * Update README.md * Update web-configurator.md * Update web-configurator.md --------- Co-authored-by: TheTrain <32771064+TheTrainGoes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed spelling and grammar across the board, replaced GP2040 with GP2040-CE where relevant, and used the newer 0.4.3 latency values (@FeralAI has even newer values available soon).
This is my first time using git with code, apologies for all the opening/closing!