-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom LED implementation #166
Merged
arntsonl
merged 10 commits into
OpenStickCommunity:main
from
FeralAI:features/custom-led
May 6, 2023
Merged
Custom LED implementation #166
arntsonl
merged 10 commits into
OpenStickCommunity:main
from
FeralAI:features/custom-led
May 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be functionally ready now. Summary of changes not directly related to this feature:
I'll add documentation for this feature over the weekend. |
arntsonl
approved these changes
May 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool!! With fluppi's changes, we'll have better stack space and fully independent LED configurations!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the firmware implementation for #107.
This PR requires OpenStickCommunity/WebConfigurator#38 for the UI updates.
A new animation mode for Custom Theme has been added. If enabled, this mode will use the new CustomTheme and CustomThemePressed animation subclasses and configured LED options to display a customized static theme with customized button color presses, as the issues requested.
In the process of debugging I reworked how the pressed animation is created since it was only created as a fallback instead of when needed like the base animations.
If we want to do any customized themes with animations that will require a larger refactor or migration of the LED controller library.