Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have optimized the stack usage of a lot of functions, as we were having issues with stack overflows recently.
These are the functions I have optimized:
fp_open_custom()
setCustomTheme()
getCustomTheme()
setDisplayOptions()
getDisplayOptions()
setLedOptions()
getLedOptions()
setAddonOptions()
getAddonOptions()
getGamepadOptions()
setGamepadOptions()
setSplashImage()
setPS4Options()
setPinMappings()
addStaticThemes()
Storage::setDefaultSplashImage()
ConfigManager::setSplashImage()
This should give us a lot more stack space headroom especially in webconfig mode.
Also, I have enabled
PICO_USE_STACK_GUARDS
in Debug builds to make it easier to find and diagnose stack overflows.