Removed harmful changes to config_legacy.cpp #404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #321 changed one of the
struct
s inconfig_legacy.cpp
. We can never do that, our pre-Protobuf migration process relies on thesestruct
s not changing.I have undone the changes and added a comment at the top of the file to prevent such errors in the future.
This PR must be merged before the next release. Otherwise, users may experience failed configuration migrations.