Small fixes to LED Animation system #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause: The Rainbow and Chase animations could have their cycle time lowered to a negative number. make_timeout_time_ms returns int64 max if given a negative value. Another frame would never be processed while in the animation. Changing animations resets the timestamp to 0, which is why switching animations after raising the cycle fixed it. Fix: Clamp the cycle time within a safe range.
Potential memory corruption in HandleEvent via unitialized animation pointers: added a guard. Changed default and copy ctor of RGB to be defaulted so that the memset complaint goes away and redundant vector or array initialization is avoided.
Compiler fixes this regardless, but its one less warning in the log.
|
Testing with FlatboxRev5RGB This issue and behavior stated in #431 are still present. This is the case even after flash_nuking the board and then flashing the build firmware from the workflow run for this PR. |
Bug is still being reported, clamp to 10...max/16 and check before timeout is set in animate call
arntsonl
approved these changes
Sep 1, 2023
|
I was able to consistently reproduce the issue before my changes. I was not able to do so with my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #431, animation state breaks for cycling animations when they are made too fast.
Also includes a fix to a potential memory corruption via Animation pointers in the AnimationStation.
Another small change to the RBG struct constructors to make them Trivial classes.
Please note, as my hitbox has not yet arrived I am unable to test these changes past simply ensuring they compile.