feat: Enable Tilt Value Configuration via WebConfig #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks neat! I will check this out today when I have some time |
Pelsin
reviewed
Sep 5, 2023
| 'tilt-2-factor-left-x-label': 'Tilt 2 Factor Left X', | ||
| 'tilt-2-factor-left-y-label': 'Tilt 2 Factor Left Y', | ||
| 'tilt-2-factor-right-x-label': 'Tilt 2 Factor Right X', | ||
| 'tilt-2-factor-right-y-label': 'Tilt 2 Factor Right Y', |
There was a problem hiding this comment.
You should be able to remove these keys if they are not translated, it should fallback to english.
Pelsin
reviewed
Sep 5, 2023
| 'tilt-2-factor-left-x-label': 'Tilt 2 Factor Left X', | ||
| 'tilt-2-factor-left-y-label': 'Tilt 2 Factor Left Y', | ||
| 'tilt-2-factor-right-x-label': 'Tilt 2 Factor Right X', | ||
| 'tilt-2-factor-right-y-label': 'Tilt 2 Factor Right Y', |
…inese and Portuguese
mthiesen
requested changes
Sep 8, 2023
proto/config.proto
Outdated
| optional int32 tiltRightAnalogRightPin = 12; | ||
|
|
||
| optional SOCDMode tiltSOCDMode = 13; | ||
| optional int32 factorTilt1LeftX = 3; |
There was a problem hiding this comment.
You should never change the tag numbers of existing protobuf fields, this breaks backwards compatibility. You can add as many new fields as you like, and you can change the order of the fields in a struct as long as the tag numbers of existing fields do not change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds the ability to configure the Tilt value through WebConfig.
Background
Different characters may require unique Tilt values to perform their intended actions. Given this, it is desirable to allow users to set these values themselves.
Usage
Users can now freely set the Tilt value through the WebConfig settings interface.
Impact
This change affects the WebConfig UI and the logic that processes the Tilt value.
Testing
Manual testing was conducted in a local environment to ensure that the Tilt value could be accurately set.
Please review. Thank you!