run 4-way filtering before SOCD cleaning #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this seems to address Example 1 of OpenStickCommunity#532 without any immediately obvious detriment to the 4-way/SOCD interaction, since I think the ordering would have only really mattered on Last Input Wins, and this improves the Last Input Wins behavior
4 tasks
arntsonl
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Example 1 of #532 without any immediately obvious detriment to the 4-way/SOCD interaction, other than it has an order of operations problem (L > D > R = nothing, but R > D > L = L).
However, #533 fixes that issue by implementing filtering better, and it fixes Example 2 of #532.
@TheTrainGoes is going to do more testing, but in my testing, these two PRs together fix #532.