Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small issues with Macros #566

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix small issues with Macros #566

merged 1 commit into from
Oct 11, 2023

Conversation

deeebug
Copy link
Contributor

@deeebug deeebug commented Oct 10, 2023

This PR makes small fixes to Macros as suggested.

Please review and merge, thank you!

mthiesen
mthiesen approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@mthiesen mthiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This addresses all the issues raised on Discord.

arntsonl
arntsonl approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@arntsonl arntsonl merged commit 96af5d9 into OpenStickCommunity:main Oct 11, 2023
58 checks passed
InfraredAces pushed a commit to InfraredAces/GP2040-CE that referenced this pull request Oct 14, 2023
@deeebug @InfraredAces
Fix small issues with Macros (OpenStickCommunity#566)
7e342ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthiesen mthiesen mthiesen approved these changes

@arntsonl arntsonl arntsonl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deeebug @mthiesen @arntsonl