Rewrite to main and add-ons debouncing #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve debouncing in a few ways: - easier to read and follow - don't run unless there are changes - change the algo to immediately take presses, only using timer if it's a release
create debounce helper functions for add-ons to leverage add to dualdirectional for testing
Some more fixes, expand debounce helper to tilt, and rewrite the debouncing for jslider and turbo. Rewritten add-ons shoulder be more consistent, readable, and potentially faster.
Add the ability to adjust debounce delay from web settings (not working), cleanup old debounce references, and fixes to debounce logic.
arntsonl
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues:
While no change in latency was measurable with my setup, the logic has changed so that presses will always take with no delays. Only release will be delayed, on a per button basis, as currently set at 5ms. Previously, presses and releases were delayed by 5ms based on change equally. Also, checks were added to avoid wasting cycles if the states haven't changed in all the debounced areas.