Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables linting for typescript, a few bug fixes #653

Merged
merged 16 commits into from
Dec 7, 2023

Conversation

Pelsin
Copy link
Contributor

@Pelsin Pelsin commented Dec 7, 2023

Tons of fixes for type/lint errors
I will do a separate PR with fixes that could affect functionality , this PR should be mostly formating and removing of unused code.

A few bugs became apparent when going through the lint errors

Fixed:

  • Chinese flag did not render correctly
  • The latest version of the firmware is not shown and the button to download it is also never shown.

Not fixed in this PR:

  • Exporting/importing does not work

Removes around 120 errors, but still a few left. One step at a time :)
Skärmavbild 2023-12-07 kl  18 48 54

Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fixes! That's a lot of catches, nice.

@arntsonl arntsonl merged commit 28efc6c into OpenStickCommunity:main Dec 7, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants