use if-else block logic instead of switch in jslider debouncer #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not going to say we *understand* why this fixes OpenStickCommunity#790, but it appears to.
Closed
arntsonl
approved these changes
Jan 14, 2024
arntsonl
added a commit
that referenced
this pull request
Jan 14, 2024
* use if-else block logic instead of switch in jslider debouncer (#793) I'm not going to say we *understand* why this fixes #790, but it appears to. * Adds a "pin viewer" in pin mapping page (#794) --------- Co-authored-by: Brian S. Stephan <bss@incorporeal.org> Co-authored-by: Pelsin <ian@vidales.se>
|
@jfedor2 nailed it, the switch statements didn't have breaks in them!! |
arntsonl
added a commit
that referenced
this pull request
Jan 16, 2024
* First initial draft of pin-assignment in board config * Clean-ups to board configs * Quick fix on gpioaction * Pulling main into my gpio pin config branch (#797) * use if-else block logic instead of switch in jslider debouncer (#793) I'm not going to say we *understand* why this fixes #790, but it appears to. * Adds a "pin viewer" in pin mapping page (#794) --------- Co-authored-by: Brian S. Stephan <bss@incorporeal.org> Co-authored-by: Pelsin <ian@vidales.se> --------- Co-authored-by: Brian S. Stephan <bss@incorporeal.org> Co-authored-by: Pelsin <ian@vidales.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not going to say we understand why this fixes #790, but it appears to.