Custom theme pressed color variable fade #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arntsonl
requested changes
Jan 19, 2024
| } | ||
|
|
||
| #define PRESS_COOLDOWN_INCREMENT 500 |
There was a problem hiding this comment.
stick these at the top of the C++ file as well, makes it much easier for someone else to come in and find them
|
|
||
| absolute_time_t lastUpdateTime = nil_time; | ||
|
|
||
| uint32_t updateTimeInms = 10; |
There was a problem hiding this comment.
This is super nit picky but updateTimeInms -> updateTimeInMs
src/config_legacy.cpp
Outdated
| @@ -398,6 +398,7 @@ namespace ConfigLegacy | |||
| uint32_t customThemeR3Pressed; | |||
| uint32_t customThemeA1Pressed; | |||
| uint32_t customThemeA2Pressed; | |||
| uint32_t customThemeCooldownTimeInMs; | |||
There was a problem hiding this comment.
We also don't touch anything in config_legacy.cpp, this is kind of an internal knowledge thing so super easy to miss. You can remove any changes to config_legacy.cpp
src/configs/webconfig.cpp
Outdated
|
|
||
|
|
arntsonl
reviewed
Jan 19, 2024
src/config_legacy.cpp
Outdated
| @@ -397,7 +397,7 @@ namespace ConfigLegacy | |||
| uint32_t customThemeL3Pressed; | |||
| uint32_t customThemeR3Pressed; | |||
| uint32_t customThemeA1Pressed; | |||
| uint32_t customThemeA2Pressed; | |||
| uint32_t customThemeA2Pressed; | |||
There was a problem hiding this comment.
If you don't use it, TortoiseGit will give you a visual DIFF between your check-ins which can help this kind of stuff.
You can also just revert to a previous history version so you don't end up having extra spaces or tabs.
arntsonl
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Custom theme now supports blending the pressed color back into the regular color.
https://discord.com/channels/1049366310389289001/1049370387563163731/1197730363015962844
Use parameter up/down (S1+S1+(R1/R2)) to increase or decrease the fade. Defaults to 0ms blend which is the current behaviour.