update reverse input to work on the dpad state rather than pin masks #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using the core gamepad pin masks meant that anything that was adding to/modifying dpad state was being overwritten because they probably fired before reverse input, and thus their change to the gamepad state was being dropped because the GPIO pins themselves were inactive, so the reverse input logic thought the outputs were inactive and assigned to the dpad e.g. 0 | 0 | 0 | 0 | 0 this fixes reverse input + DDI entirely, and also allows the proper SOCD of the dpad(s) to be inverted rather than dropped. note that reverse input only works against the dpad, I don't know if that's intended or not, but I'm leaving it as is. Fixes OpenStickCommunity#822
arntsonl
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the core gamepad pin masks meant that anything that was adding to/modifying dpad state was being overwritten because they probably fired before reverse input, and thus their change to the gamepad state was being dropped because the GPIO pins themselves were inactive, so the reverse input logic thought the outputs were inactive and assigned to the dpad e.g. 0 | 0 | 0 | 0 | 0
this fixes reverse input + DDI entirely, and also allows the proper SOCD of the dpad(s) to be inverted rather than dropped.
note that reverse input only works against the dpad, I don't know if that's intended or not, but I'm leaving it as is.
Fixes #822