Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Zip to fix reference crash issue #5

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Reimplement Zip to fix reference crash issue #5

merged 3 commits into from
Dec 20, 2023

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Dec 20, 2023

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (0cd6e02) 97.88% compared to head (4dafccb) 97.67%.

Files Patch % Lines
...ources/OpenCombine/Publishers/Publishers.Zip.swift 90.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   97.88%   97.67%   -0.21%     
==========================================
  Files         105      105              
  Lines        7708     7708              
==========================================
- Hits         7545     7529      -16     
- Misses        163      179      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit 98fed00 into main Dec 20, 2023
9 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/zip branch December 20, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zip crash
2 participants