Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new OpenStack IA #276

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Support new OpenStack IA #276

merged 1 commit into from
Mar 28, 2022

Conversation

lharzenetter
Copy link
Member

@lharzenetter lharzenetter commented Mar 28, 2022 •
edited
Loading

The new OpenStack IA requires specific handling of inputs

  • Fix get inputs: somehow the plan wants to have the HypervisorTenantID, HypervisorUserName, and HypervisorUserPassword as inputs. However, they are not required anymore and the corresponding code in BPELUbuntuVmTypePluginHandler::909 is not executed. @nyuuyn do you have an idea why they appear?

OpenTOSCA/tosca-definitions-common#21 depends on this.

nyuuyn
nyuuyn approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@nyuuyn nyuuyn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should refactor this plugin and the nodetype(s) in the future to the patternbased plugin to reduce code and complexity

wederbn
wederbn approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@wederbn wederbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree with Kalles comment. Maybe create an issue when merging this

@lharzenetter lharzenetter merged commit 92b5ebf into master Mar 28, 2022
@lharzenetter lharzenetter deleted the supportNewOpenStack branch March 28, 2022 15:26
@lharzenetter lharzenetter mentioned this pull request Mar 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyuuyn nyuuyn nyuuyn approved these changes

@wederbn wederbn wederbn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lharzenetter @nyuuyn @wederbn