Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #164 AsyncHBase compatibility with HBase 1.3.1 #169

Closed
wants to merge 1 commit into from

Conversation

karanmehta93
Copy link
Contributor

Following changes are made.

  1. Client Protos upgraded from HBase 0.98 to 1.3
  2. Makefiles modified for adding new files
  3. Handling of 'more_results_in_region' bit in ScanResponse
    If this bit is unset then new GetNextRowsRequest is not issued since the scanner will be already closed on server side and will result into exceptions on client side if the RPC is still made.
  4. Added an integration test that scans across multiple regions, thus involving multiple open, close and getnextrows requests.

@karanmehta93
Copy link
Contributor Author

I am also not sure as to why the build is failing.

@karanmehta93
Copy link
Contributor Author

@manolama
Can you review it?

splitTable(table, "s10");
splitTable(table, "s20");
splitTable(table, "s30");
List<Deferred<Object>> list = new ArrayList<>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <> isn't allowed in Java 6. We're still bw compatible for existing users.

@manolama
Copy link
Member

manolama commented Jun 8, 2017

Drats, just tested. It works fine with 1.3.1 but breaks with previous versions (at least 1.0.0 and 1.1.2)

@karanmehta93
Copy link
Contributor Author

Let me check it once again. I tested it with 0.98, 1.2, 1.3 and worked fine. Can you point to the location from where you got these versions and what errors you found?
Also can you describe which other versions I should check with?

@manolama
Copy link
Member

manolama commented Jun 8, 2017

0.98 worked, lemme double check the 1.0.0 and 1.1.

@manolama
Copy link
Member

manolama commented Jun 8, 2017

1.1.2 is here: https://archive.apache.org/dist/hbase/1.1.2/
and here's the 1.0.0: https://archive.apache.org/dist/hbase/hbase-1.0.0/
Still playing around with em.

@manolama
Copy link
Member

manolama commented Jun 8, 2017

Never mind, I had some goof-up with different HBase versions pointing at the same files :) I'll fix the integration test and merge.

@manolama
Copy link
Member

manolama commented Jun 8, 2017

Merged in 80c6b86. Thanks!

@manolama manolama closed this Jun 8, 2017
@karanmehta93
Copy link
Contributor Author

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants