Normalize tag support #1525
Open
Normalize tag support #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ace409b)
johann8384
requested changes
May 15, 2019
| @@ -14,7 +14,7 @@ | |||
| # along with this library. If not, see <http://www.gnu.org/licenses/>. | |||
|
|
|||
| # Semantic Versioning (see http://semver.org/). | |||
| AC_INIT([opentsdb], [2.4.0], [opentsdb@googlegroups.com]) | |||
| AC_INIT([opentsdb], [2.4.0-tnp], [opentsdb@googlegroups.com]) | |||
There was a problem hiding this comment.
We probably don't need this change.
| @@ -12,59 +12,17 @@ | |||
| // see <http://www.gnu.org/licenses/>. | |||
| package net.opentsdb.core; | |||
|
|
|||
| import java.io.File; | |||
There was a problem hiding this comment.
So, it looks like you did the "auto format" in IntelliJ, I've been tempted to commit this myself. Would it be possible to isolate just the changes relevant to your new plugin type?
I love the concept and would be happy to get this merged if we can remove the unrelated changes.
| @@ -28,7 +28,7 @@ | |||
| * after they are queued for storage. In the future we may support publishing | |||
| * meta data or other types of information as changes are made. | |||
| * <p> | |||
| * <b>Note:</b> Implementations must have a parameterless constructor. The | |||
There was a problem hiding this comment.
You can leave in all the "trailing whitespace" fixes if you want! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new plugin type allows you to provide a plugin to normalize tags. My use case for implementing this is the fact that the slew of Cloud Native systems coming online all export their metrics slightly differently and opentsdb doesn't support fuzzy matches or specifying which tags are equivalent to each other.
I was receiving container, container-name, container_name, etc., etc., etc.
This plugin type requires a normalizeTags(tags) method. The tags are passed in and a normalized set are returned.