Issue 839: Trigger DPsResolver deferreds in chunks #2200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added tsdb_list_running_queries.py * updated error handling * updated tsdb_list_running_queries.py * various cleanup, removal of old code etc * switched to custom ConnectionException * added comment for now_length Co-authored-by: Hari Sekhon <Hari.Sekhon@gresearch.co.uk>
The / at the end of url makes url in this form https://repo1.maven.org/maven2/com/pythian/opentsdb/asyncbigtable/0.3.0//asyncbigtable-0.3.0-jar-with-dependencies.jar but that "//" in the url makes a 404!
…r the Gnuplot params and introducting the tsd.gnuplot.options.allowlist setting that is a strict matching allow list of o= values from the query string that will be allowed through. By default tihs is empty so if folks are using this query param, they'll different graphs until they add the options they need.
defined in the config file. Fixes OpenTSDB#2033
… and allow for no filters.
Ensure the scanner callback waits for all the UIDs to resolve before calling scan to retrieve the next set of results. Not waiting would cause the scanner to close prematurely and return incomplete results.
bshakur8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #839
In clusters containing tags with high cardinality a query over multiple tags can easily overflow the maximum size of the callback chain resulting in a CallbackOverflowError when creating the callback chain for writing the resulting json output. This change writes the deferrds in chunks to avoid the overflow error.