Async delete of datapoints through HTTP #503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop setting the query endtime to Integer.MAX_VALUE by default. Add an option to enable deleting points. Set logging level of these operations to debug instead of info.
Add a config option to enable data deletion through HTTP.
One test to check that datapoints cannot be removed by default, and another to check that datapoints are indeed removed.
|
Will this be merged anytime soon? I'm using opentsdb in a cloud environment and I have a data of many hosts which have been deleted long time ago. It be really nice if ther'd be an easy way of deleting all that obsolete data. Like deleting all data (any metric) with tag host = xxx with a single query. |
|
Well one of the test is broken so I should get to fix that before merging. Other than that, do you see anything missing @manolama ? |
|
Cleaned up and merged in 7180bb5 |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #496, based on the put branch.
Still missing tests, I will get to that next.