Misc check_tsd fixes & improvements #776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes old dead code trying to use bad_percent property
Also break early, relevant when running with -N <utc> mode
|
Two questions for @stromnet:
|
|
|
yeah, that looks right. Those docs probably need and overall refresh, update it with your new functionality and I'll save the refresh for another day. |
stromnet
added a commit
to stromnet/opentsdb.net
that referenced
this pull request
Apr 18, 2016
|
PR for doc above |
|
Merging in #779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, this unbreaks #760, making the tool usable again.
It also adds a new feature, running with -N for testing against historic data, rather than just the latest data. This is very useful when tweaking parameters such as downsampling, aggregation etc, against historic data. In my case I've used it to find out which parameters would be good to trigger alarm on a temperature sensor which has a normal level, but regularly have some short peaks which I wanted to ignore.
While tweaking, I found out that one of the new downsample algorithms worked best. So I've added all the ones listed on http://opentsdb.net/docs/build/html/user_guide/query/aggregators.html#available-aggregators, both for use as downsampler and aggregator. Also made the verbose output explicitly show what it ignored.