Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Attempt at Authentication Plugin #899

Merged
merged 1 commit into from Jan 3, 2017

Conversation

johann8384
Copy link
Member

Fixes #501
Fixes #667

@johann8384 johann8384 added this to the v2.4.0 milestone Dec 2, 2016
@johann8384 johann8384 self-assigned this Dec 2, 2016
@manolama
Copy link
Member

manolama commented Dec 5, 2016

LGTM, just a few nitpicks about versioning and the only biggy is to make sure to shutdown the plugin when the TSD is shutdown. Thanks!

@johann8384
Copy link
Member Author

Thanks, I actually noticed that over the weekend and will have a few tweaks to submit.

@johann8384 johann8384 changed the base branch from put to next January 3, 2017 04:52
@johann8384 johann8384 merged commit d96393f into OpenTSDB:next Jan 3, 2017
@johann8384 johann8384 deleted the ISSUE-501 branch January 3, 2017 04:53
@IDerr IDerr mentioned this pull request Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants