Codechange: remove unused "ref" parameter

plugins/GitHub/events/pull_request.py

@@ -21,8 +21,7 @@ async def pull_request(event, github_api):
     if payload["action"] == "closed" and event.data["pull_request"]["merged"]:
         payload["action"] = "merged"
 
-    ref = event.data["pull_request"]["base"]["ref"]
-    await protocols.dispatch(github_api, repository_name, "pull-request", payload, ref=ref)
+    await protocols.dispatch(github_api, repository_name, "pull-request", payload)
 
 
 @router.register("issue_comment")
@@ -35,24 +34,16 @@ async def issue_comment(event, github_api):
 
     repository_name = event.data["repository"]["full_name"]
 
-    # To not assume Pull Request are always against 'master',
-    # we take an extra roundtrip to find the base branch
-    pull_request_url = event.data["issue"]["pull_request"]["url"]
-    assert pull_request_url.startswith("https://api.github.com/")
-    pull_request_url = pull_request_url[len("https://api.github.com") :]
-    response = await github_api.getitem(pull_request_url)
-
     payload = {
         "repository_name": repository_name,
         "pull_id": event.data["issue"]["number"],
         "url": event.data["comment"]["html_url"],
         "user": event.data["sender"]["login"],
-        "title": response["title"],
+        "title": event.data["issue"]["title"],
         "action": "comment",
     }
 
-    ref = response["base"]["ref"]
-    await protocols.dispatch(github_api, repository_name, "pull-request", payload, ref=ref)
+    await protocols.dispatch(github_api, repository_name, "pull-request", payload)
 
 
 @router.register("pull_request_review")
@@ -79,5 +70,4 @@ async def pull_request_review(event, github_api):
     ):
         return
 
-    ref = event.data["pull_request"]["base"]["ref"]
-    await protocols.dispatch(github_api, repository_name, "pull-request", payload, ref=ref)
+    await protocols.dispatch(github_api, repository_name, "pull-request", payload)

plugins/GitHub/events/push.py

@@ -80,5 +80,4 @@ async def push(event, github_api):
         "commits": commits,
     }
 
-    ref = event.data["head_commit"]["id"]
-    await protocols.dispatch(github_api, repository_name, "push", payload, ref=ref, filter_func=filter_func)
+    await protocols.dispatch(github_api, repository_name, "push", payload, filter_func=filter_func)

plugins/GitHub/helpers/dorpsgek.py

@@ -28,15 +28,15 @@ async def get_dorpsgek_yml(github_api, repository):
     return base64.b64decode(response["content"])
 
 
-async def get_notification_protocols(github_api, repository_name, ref, type):
+async def get_notification_protocols(github_api, repository_name, type):
     protocols = defaultdict(list)
     # Always inform the #dorpsgek IRC channel about everything
     protocols["irc"].append("dorpsgek")
 
     try:
         raw_yml = await get_dorpsgek_yml(github_api, repository_name)
     except Exception:
-        log.exception("Couldn't parse .dorpsgek.yml in %s at ref %s", repository_name, ref)
+        log.exception("Couldn't parse .dorpsgek.yml in %s", repository_name)
         return protocols
 
     if not raw_yml:

plugins/GitHub/helpers/protocols.py

@@ -8,8 +8,8 @@
 _protocols = defaultdict(dict)
 
 
-async def dispatch(github_api, repository_name, type, payload, ref="master", filter_func=None):
-    protocols = await get_notification_protocols(github_api, repository_name, ref, type)
+async def dispatch(github_api, repository_name, type, payload, filter_func=None):
+    protocols = await get_notification_protocols(github_api, repository_name, type)
 
     # If a filter function is set, and it returns False, don't broadcast
     # this notification