-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: [CI] switch to reusing workflows #31
Conversation
These reusing workflows also change the CDN to start using Cloudflare R2.
uses: OpenTTD/actions/.github/workflows/rw-entry-release-baseset.yml@v4 | ||
secrets: inherit | ||
with: | ||
apt-packages: catcodec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the Makefile stuff is a pain to read (well I can say unreadable), but I don't see why music pack would use catcodec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already in the workflow, so I took it over. I tried not to make any actually changes in this migration, as that shouldn't be part of this PR, but of a follow-up. There are more weird things in these repositories ... can only do so much at once :D
name: Testing | ||
uses: OpenTTD/actions/.github/workflows/rw-entry-testing-baseset.yml@v4 | ||
with: | ||
apt-packages: catcodec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous comments are not blocking
These reusing workflows also change the CDN to start using Cloudflare R2.
Depends on OpenTTD/workflows#34 and friends.