Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: [CI] switch to reusing workflows #31

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Change: [CI] switch to reusing workflows #31

merged 1 commit into from
Jul 1, 2023

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jul 1, 2023

These reusing workflows also change the CDN to start using Cloudflare R2.

Depends on OpenTTD/workflows#34 and friends.

These reusing workflows also change the CDN to start using Cloudflare R2.
@TrueBrain TrueBrain marked this pull request as ready for review July 1, 2023 10:55
uses: OpenTTD/actions/.github/workflows/rw-entry-release-baseset.yml@v4
secrets: inherit
with:
apt-packages: catcodec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the Makefile stuff is a pain to read (well I can say unreadable), but I don't see why music pack would use catcodec

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already in the workflow, so I took it over. I tried not to make any actually changes in this migration, as that shouldn't be part of this PR, but of a follow-up. There are more weird things in these repositories ... can only do so much at once :D

name: Testing
uses: OpenTTD/actions/.github/workflows/rw-entry-testing-baseset.yml@v4
with:
apt-packages: catcodec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous comments are not blocking

@TrueBrain TrueBrain merged commit 210b1e9 into master Jul 1, 2023
3 checks passed
@TrueBrain TrueBrain deleted the switch-cdn branch July 1, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants