Fix #10763, #11168: Display variant groups that consist only of unava…

…ilable sub-groups
OpenTTD · Oct 1, 2023 · 8149e5c · 8149e5c
1 parent b5dc932
commit 8149e5c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/src/autoreplace_gui.cpp b/src/autoreplace_gui.cpp
@@ -179,7 +179,13 @@ class ReplaceVehicleWindow : public Window {
 			if (side == 1 && eid == this->sel_engine[0]) flags |= EngineDisplayFlags::Shaded;
 			list.emplace_back(eid, e->info.variant_id, flags, 0);
 
-			if (side == 1 && e->info.variant_id != INVALID_ENGINE) variants.push_back(e->info.variant_id);
+			if (side == 1) {
+				EngineID parent = e->info.variant_id;
+				while (parent != INVALID_ENGINE) {
+					variants.push_back(parent);
+					parent = Engine::Get(parent)->info.variant_id;
+				}
+			}
 			if (eid == this->sel_engine[side]) selected_engine = eid; // The selected engine is still in the list
 		}
 

diff --git a/src/build_vehicle_gui.cpp b/src/build_vehicle_gui.cpp
@@ -1422,7 +1422,14 @@ struct BuildVehicleWindow : Window {
 			list.emplace_back(eid, e->info.variant_id, e->display_flags, 0);
 
 			if (rvi->railveh_type != RAILVEH_WAGON) num_engines++;
-			if (e->info.variant_id != eid && e->info.variant_id != INVALID_ENGINE) variants.push_back(e->info.variant_id);
+			if (e->info.variant_id != eid && e->info.variant_id != INVALID_ENGINE) {
+				EngineID parent = e->info.variant_id;
+				while (parent != INVALID_ENGINE) {
+					variants.push_back(parent);
+					parent = Engine::Get(parent)->info.variant_id;
+				}
+			}
+
 			if (eid == this->sel_engine) sel_id = eid;
 		}
 
@@ -1563,7 +1570,13 @@ struct BuildVehicleWindow : Window {
 		/* ensure primary engine of variant group is in list after filtering */
 		std::vector<EngineID> variants;
 		for (const auto &item : this->eng_list) {
-			if (item.engine_id != item.variant_id && item.variant_id != INVALID_ENGINE) variants.push_back(item.variant_id);
+			if (item.engine_id != item.variant_id && item.variant_id != INVALID_ENGINE) {
+				EngineID parent = item.variant_id;
+				while (parent != INVALID_ENGINE) {
+					variants.push_back(parent);
+					parent = Engine::Get(parent)->info.variant_id;
+				}
+			}
 		}
 		for (const auto &variant : variants) {
 			if (std::find(this->eng_list.begin(), this->eng_list.end(), variant) == this->eng_list.end()) {