Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Articulated Vehicles not showing correct capacity in buy menu #10032

Closed
GarlicBread42 opened this issue Sep 14, 2022 · 2 comments
Closed

[Bug]: Articulated Vehicles not showing correct capacity in buy menu #10032

GarlicBread42 opened this issue Sep 14, 2022 · 2 comments
Labels
bug Something isn't working component: NewGRF This issue is related to NewGRFs good first issue Good for newcomers

Comments

@GarlicBread42
Copy link

Version of OpenTTD

12.2

Expected result

When a non-default cargo is chosen from the buy menu, vehicle should show the actual capacity of the whole vehicle.

Actual result

If a non-default cargo is chosen from the buy menu, buy menu shows two lines of capacity.
One is displaying a wrong result for the default cargo the vehicle is coded in, the other line shows a different capacity.

grafik
grafik

When bought, the cargo capacity is as intended by the newgrf.
grafik

Steps to reproduce

  1. Choose any articulated vehicle in the buy menu
  2. Switch Cargo in buy menu to any refittable cargo.
@andythenorth
Copy link
Contributor

One clarification to repro steps. The bug doesn't manifest when the filtered cargo matches the default cargo for the units of the articulated vehicle.

@glx22
Copy link
Contributor

glx22 commented Sep 14, 2022

Weight is wrong too.
#9954 is a related issue.

@telk5093 telk5093 mentioned this issue Sep 16, 2022
Open
JGRennison added a commit to JGRennison/OpenTTD-patches that referenced this issue Sep 16, 2022
@JGRennison
Fix displayed capacities/weights of articulated vehicles in build window
c7e4dbf 
Simplify handling of multi-part capacities and refits

See: OpenTTD/OpenTTD#9954
See: OpenTTD/OpenTTD#10032
@2TallTyler 2TallTyler added good first issue Good for newcomers component: NewGRF This issue is related to NewGRFs bug Something isn't working labels Oct 19, 2022
@PeterN PeterN mentioned this issue Jan 5, 2023
Closed
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Jan 6, 2023
@JGRennison
Fix OpenTTD#10032: Capacities of articulated vehicles in build window
7f561e2 
When refits are in effect

See also: OpenTTD#9954
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Jan 6, 2023
@JGRennison
Fix OpenTTD#10032: Capacities of articulated vehicles in build window
b206137 
See also: OpenTTD#9954
@JGRennison JGRennison mentioned this issue Jan 6, 2023
Merged
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Jan 7, 2023
@JGRennison
Fix OpenTTD#10032: Capacities of articulated vehicles in build window
915c729 
See also: OpenTTD#9954
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Jan 7, 2023
@JGRennison
Fix OpenTTD#10032: Capacities of articulated vehicles in build window
f17dc87 
See also: OpenTTD#9954
michicc pushed a commit to michicc/OpenTTD that referenced this issue Jan 27, 2023
@JGRennison @michicc
Fix OpenTTD#10032: Capacities of articulated vehicles in build window
167ad16 
See also: OpenTTD#9954
michicc pushed a commit to michicc/OpenTTD that referenced this issue Jan 28, 2023
@JGRennison @michicc
Fix OpenTTD#10032: Capacities of articulated vehicles in build window
22800b8 
See also: OpenTTD#9954
michicc pushed a commit that referenced this issue Jan 28, 2023
@JGRennison @michicc
Fix #10032: Capacities of articulated vehicles in build window
bd6a95c 
See also: #9954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component: NewGRF This issue is related to NewGRFs good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andythenorth @glx22 @2TallTyler @GarlicBread42