Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crash]: Crash trying to build objects on area #10135

Closed
leonengel opened this issue Nov 5, 2022 · 1 comment · Fixed by #10137
Closed

[Crash]: Crash trying to build objects on area #10135

leonengel opened this issue Nov 5, 2022 · 1 comment · Fixed by #10137
Assignees
@2TallTyler
Labels
bug Something isn't working

Comments

@leonengel
Copy link

Version of OpenTTD

13.0-beta1 (2022-10-31)

Steps to reproduce

  1. Selected an object
  2. Tried drag-and-drop on an area
  3. Game crash

Upload crash files

OpenTTD13BetaCrash.zip
@James103
Copy link
Contributor

James103 commented Nov 5, 2022 •
edited

Can reproduce in d48a48b using OpenGFX Landscape NewGRF.

The wind turbines have placement restrictions which means no two turbines can be on adjacent tiles.

The test run returns with an estimate of 9 turbines able to be constructed on a 3x3 area, but actually only 5 turbines can be constructed in the same area. This difference results in a cost difference between the test run and the exec run, which triggers an assert; therefore, the game crashes.

JGRPP implements the command differently in such a way that doing the same steps there does not assert or crash.

@2TallTyler 2TallTyler self-assigned this Nov 5, 2022
@2TallTyler 2TallTyler added the bug Something isn't working label Nov 5, 2022
2TallTyler added a commit to 2TallTyler/OpenTTD that referenced this issue Nov 5, 2022
@2TallTyler
Fix OpenTTD#10135: Cost of building multiple objects might not match …
ff3d9a0 
…test
@2TallTyler 2TallTyler mentioned this issue Nov 5, 2022
Merged
2TallTyler added a commit that referenced this issue Nov 5, 2022
@2TallTyler
Fix #10135: Cost of building multiple objects might not match test (#…
0172eb3 
…10137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2TallTyler 2TallTyler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #10135: Cost of building multiple objects might not match test 2TallTyler/OpenTTD
3 participants
@James103 @2TallTyler @leonengel