Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-way road arrows don't look good on slopes #10238

Closed
PikkaBird opened this issue Dec 14, 2022 · 2 comments
Closed

One-way road arrows don't look good on slopes #10238

PikkaBird opened this issue Dec 14, 2022 · 2 comments
Labels
component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests!

Comments

@PikkaBird
Copy link

PikkaBird commented Dec 14, 2022

Version of OpenTTD

13.0 b2

Expected result

Both the base graphics and newgrfs treat the one-way arrows as diegetic, ie as if they were in-game road markings rather a UI indicator. Action 5 type 09 should be extended with an additional 12 sprites to allow providing sloped versions of the one-way arrows.

Actual result

The one-way arrows do not have sloped versions and thus look naff on slopes.
Jollyburg Transport, 1976-09-30

Steps to reproduce

Build a one-way road on a slope.

@LC-Zorg

This comment was marked as off-topic.

@2TallTyler 2TallTyler added component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests! labels Dec 15, 2022
FLHerne added a commit to FLHerne/OpenTTD that referenced this issue Dec 25, 2022
Per OpenTTD#10238, the baseset only provided one-way sprites for flat tiles,
 matching the default road type. These look bad on slopes or on
 some custom roadtypes.

Action5 type 0x09 is extended to accept a set of 18 sprites.
The first 6 are unchanged from before this patch, followed by
 similar groups for north-facing and then south-facing slopes.

For compatibility with older basesets and NewGRFs, if an Action5
 provides only sprites for flat tiles these will be used on slopes
 as in previous versions.

Action3 type 0x0B, for roadtypes only, may optionally provide a
 set of 18 sprites as above for use with that roadtype.
FLHerne added a commit to FLHerne/OpenTTD that referenced this issue Dec 25, 2022
Per OpenTTD#10238, the baseset only provided one-way sprites for flat tiles,
 matching the default road type. These look bad on slopes or on
 some custom roadtypes.

Action5 type 0x09 is extended to accept a set of 18 sprites.
The first 6 are unchanged from before this patch, followed by
 similar groups for north-facing and then south-facing slopes.

For compatibility with older basesets and NewGRFs, if an Action5
 provides only sprites for flat tiles these will be used on slopes
 as in previous versions.

Action3 type 0x0B, for roadtypes only, may optionally provide a
 set of 18 sprites as above for use with that roadtype.
FLHerne added a commit to FLHerne/OpenTTD that referenced this issue Dec 26, 2022
Per OpenTTD#10238, the baseset only provided one-way sprites for flat tiles,
 matching the default road type. These look bad on slopes or on
 some custom roadtypes.

Action5 type 0x09 is extended to accept a set of 18 sprites.
The first 6 are unchanged from before this patch, followed by
 similar groups for north-facing and then south-facing slopes.

For compatibility with older basesets and NewGRFs, if an Action5
 provides only sprites for flat tiles these will be used on slopes
 as in previous versions.

Action3 type 0x0B, for roadtypes only, may optionally provide a
 set of 18 sprites as above for use with that roadtype.

Sprites for sloped tiles are added to openttd.grf, used when
 no one-way sprites are provided by the baseset (i.e. when using
 the original TTD graphics).
FLHerne added a commit to FLHerne/OpenTTD that referenced this issue Dec 26, 2022
Per OpenTTD#10238, the baseset only provided one-way sprites for flat tiles,
 matching the default road type. These look bad on slopes or on
 some custom roadtypes.

Action5 type 0x09 is extended to accept a set of 18 sprites.
The first 6 are unchanged from before this patch, followed by
 similar groups for north-facing and then south-facing slopes.

For compatibility with older basesets and NewGRFs, if an Action5
 provides only sprites for flat tiles these will be used on slopes
 as in previous versions.

Action3 type 0x0B, for roadtypes only, may optionally provide a
 set of 18 sprites as above for use with that roadtype.

Sprites for sloped tiles are added to openttd.grf, used when
 no one-way sprites are provided by the baseset (i.e. when using
 the original TTD graphics).
@michicc
Copy link
Member

michicc commented Dec 26, 2022

Support added in #10282

@michicc michicc closed this as completed Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests!
Projects
None yet
Development

No branches or pull requests

4 participants