[Crash]: Downloading a Game Script while having another Game Script selected may crash

[James103]

Version of OpenTTD

a857ed8 on Windows 10, 64-bit (via Steam)

Steps to reproduce

1. Download some Game Scripts, including one that has parameters.
2. From the main menu, click "Game Script Settings".
3. Select an installed Game Script with parameters.
4. From the console, run rescangame. The game may or may not crash right then.
5. Click "Check Online Content".
6. Download some more Game Scripts, then close the content downloading window which will run rescangame again to detect the newly downloaded Game Scripts.
7. The game may or may not crash then as well. If not, repeat from step 3 with a different Game Script selected.

Upload crash files

crash20221222153328.zip
crash20221222153102.zip

Originally reported in JGRennison/OpenTTD-patches#465, but I was able to reproduce in vanilla.

[glx22]

Seems to be a nasty one, crash.log are mentioning infinite loops.

[JGRennison]

It's just a dangling pointer heap use after free type bug. I'll sort something out later if I get time.

Edit: Better stack traces here: JGRennison/OpenTTD-patches#465 (comment)