Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Noise control setting doesn't describe airport number limit well #10478

Closed
EratoNysiad opened this issue Feb 14, 2023 · 6 comments
Closed
Assignees
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests!

Comments

@EratoNysiad
Copy link
Contributor

Version of OpenTTD

13.0, Windows 10

Expected result

image
When this setting is set to "Off", I expect to be able to place an unlimited amount of airports

Actual result

image
I am limited to only 2 airports, regardless of what this is set to

Steps to reproduce

  1. Set the "Allow town controlled noise level for airports" setting to "Off"
  2. Attempt to place 3 airports near a single town.
@James103
Copy link
Contributor

Workaround:

  1. Install the NewGRF "OpenGFX+ Airports" with the disable airport noise limits parameter enabled.
  2. Turn on "Allow town controlled noise level for airports"
  3. You should now be able to build many more airports near a single town.

@PikkaBird
Copy link

With the noise limit setting off, the game reverts to the default TTD behaviour of allowing only two airports per town.

There are two ways to allow building unlimited airports:

  1. turn noise limits off, and set "Local authority attitude" to "Permissive".
  2. turn noise limits on, and use a GRF that sets airport noise to 0, as James103 mentioned.

@EratoNysiad
Copy link
Contributor Author

EratoNysiad commented Feb 14, 2023

The "Local authority attitude" setting has no effect on the amount of airports when the noise setting is off, but with the setting on it works brilliantly, thanks.

Correction; that is what it should do, and what it does in JGR
While the setting description says "With this setting disabled, there can be two airports in each town," this is not actually the case in 13.0

@PikkaBird
Copy link

PikkaBird commented Feb 14, 2023

The way it functions in 13.0 is correct according to the PR which added the functionality (#9833). It's interesting that it works differently in JGRPP, but doesn't necessarily make either implementation "wrong".

The setting description is out-of-date and doesn't reflect the changes in #9833. That could definitely be considered a bug.

@2TallTyler 2TallTyler changed the title [Bug]: Noise control setting not disabling airport restrictons [Bug]: Noise control setting doesn't describe airport number limit well Feb 18, 2023
@2TallTyler 2TallTyler added the enhancement Issue would be a good enhancement; we accept Pull Requests! label Feb 18, 2023
@2TallTyler 2TallTyler self-assigned this Apr 21, 2023
@2TallTyler
Copy link
Member

2TallTyler commented Apr 21, 2023

I don't quite understand this report. Which setting helptext isn't descriptive enough?

I changed it, so I'll fix it, I just need to know what needs updating. 😃

@PikkaBird
Copy link

PikkaBird commented Apr 22, 2023

The "bug" in the description text for 'Allow town controlled noise level for airports' is that "With this setting disabled, there can be two airports in each town" is no longer true if 'local authority attitude' is set to 'permissive'.

This functionality being affected by two different settings, as well as potentially newgrf, is a bit of a mess. :) But the real confusion that resulted in this bug report stems from JGRPP implementing the interaction between the two settings differently from vanilla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests!
Projects
None yet
Development

No branches or pull requests

4 participants