Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Crash log no longer works for crashes which occur before FontCache::InitializeFontCaches #10993

Closed
JGRennison opened this issue Jun 11, 2023 · 0 comments
Closed

[Bug]: Crash log no longer works for crashes which occur before FontCache::InitializeFontCaches #10993

JGRennison opened this issue Jun 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

Since #10836 / f454ec8

Expected result

Crash log works as far as is reasonably practical

Actual result

InitializeFontCaches is now called fairly late into the initialisation process due to the changes in #10836, but the crash log assumes that they are always present, and so attempts to dereference them, resulting in no useful output at all.

Possible fix: JGRennison/OpenTTD-patches@aa8b60d ?

Steps to reproduce

Synthesise a crash somewhere early (e.g. in InitializeLanguagePacks).
@2TallTyler 2TallTyler added the bug Something isn't working label Jun 13, 2023
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Jun 16, 2023
@JGRennison
Fix OpenTTD#10993: Crash log when font caches not initialised
e8ff5a7 
See also: OpenTTD#10836
@JGRennison JGRennison mentioned this issue Jun 16, 2023
Merged
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Jun 17, 2023
@JGRennison
Fix OpenTTD#10993: Crash log when font caches not initialised
d065524 
See also: OpenTTD#10836
@PeterN PeterN closed this as completed in a6b625e Jun 17, 2023
mrmbernardi pushed a commit to mrmbernardi/OpenTTD that referenced this issue Jul 2, 2023
@JGRennison @mrmbernardi
Fix OpenTTD#10993: Crash log when font caches not initialised (OpenTT…
6574ba7 
…D#11024)

See also: OpenTTD#10836
shoter pushed a commit to shoter/OpenTTD that referenced this issue Jul 16, 2023
@JGRennison @shoter
Fix OpenTTD#10993: Crash log when font caches not initialised (OpenTT…
fc5513c 
…D#11024)

See also: OpenTTD#10836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JGRennison @2TallTyler