Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Max competitors is ignored when AI interval is zero #11179

Closed
James103 opened this issue Aug 11, 2023 · 0 comments · Fixed by #11185
Closed

[Bug]: Max competitors is ignored when AI interval is zero #11179

James103 opened this issue Aug 11, 2023 · 0 comments · Fixed by #11185
Labels
bug Something isn't working

Comments

@James103
Copy link
Contributor

Version of OpenTTD

ba95764 on Windows 10, 64-bit (via Steam)

Expected result

When "Interval between starting of competitors" is zero, "Maximum no. competitors" is respected.

Actual result

When "Interval between starting of competitors" is zero, "Maximum no. competitors" is not respected properly and is instead treated as if it was set to the maximum number of companies in total (less one for the human player).

Steps to reproduce

  1. Set "Interval between starting of competitors" to zero.
  2. Set "Maximum no. competitors" to any positive value.
  3. Start a new game.
  4. Fast-forward.
  5. Every 10 minutes of game time, a new AI is spun up, even if that would place the total AI count over the limit set by "Maximum no. competitors."
@2TallTyler 2TallTyler added bug Something isn't working regression It used to work, and now it's broken. and removed regression It used to work, and now it's broken. labels Aug 11, 2023
glx22 added a commit to glx22/OpenTTD that referenced this issue Aug 11, 2023
@glx22
Fix OpenTTD#11179, a979d9c: Don't start more competitors than allowed
4f5da5a
@glx22 glx22 mentioned this issue Aug 11, 2023
Merged
glx22 added a commit to glx22/OpenTTD that referenced this issue Aug 11, 2023
@glx22
Fix OpenTTD#11179, a979d9c: Don't start more competitors than allowed
b87a162
glx22 added a commit that referenced this issue Aug 11, 2023
@glx22
Fix #11179, a979d9c: Don't start more competitors than allowed (#11185)
02be6ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #11179, a979d9c: Don't start more competitors than allowed glx22/OpenTTD
2 participants
@James103 @2TallTyler