Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: LinkType one definition rule violation #11500

Closed
JGRennison opened this issue Nov 26, 2023 · 0 comments
Closed

[Bug]: LinkType one definition rule violation #11500

JGRennison opened this issue Nov 26, 2023 · 0 comments

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

master

Expected result

No warnings

Actual result

enum class LinkType is defined in textfile_gui.cpp
enum LinkType : byte is defined in league_type.h

This seems to generate warnings about violating the one definition rule on some platforms/build configurations when using LTO, e.g. linux generic release.
I've also noticed this when doing LTO with MinGW.

This doesn't appear to prevent successful builds.

Steps to reproduce

See above
PeterN added a commit to PeterN/OpenTTD that referenced this issue Nov 27, 2023
@PeterN
Fix OpenTTD#11500: Rename Textfile GUI's LinkType to HyperlinkType.
8cb00ef 
This disambiguates it with LinkType in league tables.
@PeterN PeterN closed this as completed in e3622da Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JGRennison