Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When building a path through an existing one, the path is also laid under bridges #11528

Open
DefinitelyNotRau117 opened this issue Dec 2, 2023 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@DefinitelyNotRau117
Copy link

Version of OpenTTD

OpenTTD 20231121; Windows 10

Expected result

The area under/after the bridge is not affected, the rails/roads are laid up to the first tile of the bridge

Actual result

The first time everything works as it should, but if you re-lay tracks through an existing one, the tracks will be laid under the bridge.

2023-12-02.19-37-37.mp4

The bug also appears on roads, tunnels and diagonal tracks.

2023-12-02.19-35-26.mp4
2023-12-02.19-50-19.mp4

Steps to reproduce

  1. Build a bridge and a path across it
  2. Pass the new path through existing one again
@JGRennison
Copy link
Contributor

This functionality change was made by #11089

@DefinitelyNotRau117
Copy link
Author

This functionality change was made by #11089

This is not what the bug report is about, for the first time, building before the bridge is working as expected.
This bug report that if you do this a second time, the rails will be built below the bridge.

For example, this could result in signals being removed under a bridge. And if there is a programmable signal under the bridge, this may become a more intrusive problem.

2023-12-03.01-30-19.mp4

@JGRennison
Copy link
Contributor

This functionality change was made by #11089

This is not what the bug report is about, for the first time, building before the bridge is working as expected. This bug report that if you do this a second time, the rails will be built below the bridge.

On the contrary, the change in #11089 is what what this bug report is about. If you revert that commit then the bug as you've described it disappears.
To spell it out, the bridge head tile is the "invalid tile" as mentioned in #11089, and the whole purpose of #11089 is to allow the sort of behaviour which is described in this bug. Whether this is actually good/useful is a separate question.

@PeterN
Copy link
Member

PeterN commented Dec 2, 2023

#11089 is the cause of this issue but that doesn't mean this specific behaviour with bridges is intentional.

IMHO, building over a bridge ramp from one side to another should continue after it, and building from underneath the bridge should continue until the bridge ramp.

@Eddi-z
Copy link
Contributor

Eddi-z commented Dec 3, 2023

I agree with @PeterN here, this behaviour seems neither intuitive nor helpful.

@2TallTyler 2TallTyler added good first issue Good for newcomers bug Something isn't working labels Dec 5, 2023
LordAro added a commit to LordAro/OpenTTD that referenced this issue Dec 19, 2023
LordAro added a commit to LordAro/OpenTTD that referenced this issue Dec 30, 2023
@glx22 glx22 reopened this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants