Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Incorrect payment for aircraft mail secondary cargo #12415

Closed
SamuXarick opened this issue Apr 3, 2024 · 0 comments
Closed

[Bug]: Incorrect payment for aircraft mail secondary cargo #12415

SamuXarick opened this issue Apr 3, 2024 · 0 comments

Comments

@SamuXarick
Copy link
Contributor

Version of OpenTTD

20240403-master-g931aa39018

Expected result

Cargo packets' current_tile is the tile the aircraft was at for aircraft mail secondary cargo.

Actual result

Cargo packets' current_tile is 0 for aircraft mail secondary cargo.

Steps to reproduce

All problems appear to be the usage of v->tile on economy.cpp, lines:
1304
1444
1479
1570
1704
1731
1801
glx22 added a commit to glx22/OpenTTD that referenced this issue Apr 3, 2024
@glx22
Fix OpenTTD#12415: Aircraft::tile is valid only for front vehicle
c9c65b0
glx22 added a commit to glx22/OpenTTD that referenced this issue Apr 3, 2024
@glx22
Fix OpenTTD#12415, 9c49a61: Aircraft::tile is valid only for front ve…
c2bb9de 
…hicle
@glx22 glx22 mentioned this issue Apr 3, 2024
Merged
glx22 added a commit to glx22/OpenTTD that referenced this issue Apr 3, 2024
@glx22
Fix OpenTTD#12415, 9c49a61, df400ef: Aircraft::tile is valid only for…
7644a72 
… front vehicle
@glx22 glx22 closed this as completed in 243c6be Apr 3, 2024
glx22 added a commit to glx22/OpenTTD that referenced this issue Apr 9, 2024
@glx22
Fix OpenTTD#12415, 9c49a61, df400ef: Aircraft::tile is valid only for…
b7512b7 
… front vehicle (OpenTTD#12416)
glx22 added a commit to glx22/OpenTTD that referenced this issue Apr 9, 2024
@glx22
Fix OpenTTD#12415, 9c49a61, df400ef: Aircraft::tile is valid only for…
e335043 
… front vehicle (OpenTTD#12416)
rubidium42 pushed a commit to rubidium42/OpenTTD that referenced this issue Apr 9, 2024
@glx22 @rubidium42
Fix OpenTTD#12415, 9c49a61, df400ef: Aircraft::tile is valid only for…
d9e11d5 
… front vehicle (OpenTTD#12416)
rubidium42 pushed a commit to rubidium42/OpenTTD that referenced this issue Apr 9, 2024
@glx22 @rubidium42
Fix OpenTTD#12415, 9c49a61, df400ef: Aircraft::tile is valid only for…
7a23eb0 
… front vehicle (OpenTTD#12416)
glx22 added a commit that referenced this issue Apr 9, 2024
@glx22
Fix #12415, 9c49a61, df400ef: Aircraft::tile is valid only for front …
ee2ee15 
…vehicle (#12416)
ladysadie pushed a commit to ladysadie/OpenTTD_WIP that referenced this issue Apr 10, 2024
@glx22 @ladysadie
Fix OpenTTD#12415, 9c49a61, df400ef: Aircraft::tile is valid only for…
365d64a 
… front vehicle (OpenTTD#12416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SamuXarick