Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12415, 9c49a61, df400ef: Aircraft::tile is valid only for front vehicle #12416

Merged
merged 1 commit into from Apr 3, 2024

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Apr 3, 2024

Motivation / Problem

As per #12415, v->tile for aircraft shadow/rotor is always 0.

Description

Use tile from front part of the aircraft.

Limitations

Wondering if we should initialise Vehicle::tile to INVALID_TILE in Vehicle::Vehicle(VehicleType type).

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 changed the title Fix #12415, 9c49a61: Aircraft::tile is valid only for front vehicle Fix #12415, 9c49a61, df400ef: Aircraft::tile is valid only for front vehicle Apr 3, 2024
@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label Apr 3, 2024
Copy link
Contributor

@rubidium42 rubidium42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialising as invalid might indeed be a good idea. Potentially use a default member initializer, or maybe add the tile to the constructor so every vehicle needs to explicitly set it. Either way would be out of scope for this PR I'd say.

@glx22 glx22 merged commit 243c6be into OpenTTD:master Apr 3, 2024
16 checks passed
@glx22 glx22 deleted the fix_12415 branch April 3, 2024 21:16
glx22 added a commit to glx22/OpenTTD that referenced this pull request Apr 9, 2024
glx22 added a commit to glx22/OpenTTD that referenced this pull request Apr 9, 2024
rubidium42 pushed a commit to rubidium42/OpenTTD that referenced this pull request Apr 9, 2024
rubidium42 pushed a commit to rubidium42/OpenTTD that referenced this pull request Apr 9, 2024
glx22 added a commit that referenced this pull request Apr 9, 2024
@glx22 glx22 added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 9, 2024
ladysadie pushed a commit to ladysadie/OpenTTD_WIP that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants