Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building drive through road stop on town-owned one-way road crashes game. #7626

Closed
James103 opened this issue Jun 18, 2019 · 5 comments
Milestone

Comments

@James103
Copy link
Contributor

@James103 James103 commented Jun 18, 2019

Version of OpenTTD

20190603-master-g846fc8fe09
(and probably any version after merge of PR #7547)

Expected result

The drive through road stop is built and the game does not crash.

Actual result

When you try to build a drive through road stop on any town-owned one-way road, it fails and crashes the game with Assertion failed at line 311 of d:\a\1\s\src\company_cmd.cpp: owner != OWNER_TOWN || tile != 0.
crash.zip

Steps to reproduce

  1. Load up a saved game/scenario with town-owned one-way roads, e.g. Cindini.
  2. Make sure that the game is unpaused or that "command_pause level" == 3 (Advanced Settings -> Limitations -> When paused allow: All actions)
  3. Make sure that "road_stop_on_town_road" == true (Advanced Settings -> Limitations -> Allow drive through stops on town owned roads: On)
  4. Try to build a road stop on a town-owned one-way road. If it would be successful (before the money check), then it instead crashes the game.
@EgyLynx

This comment has been minimized.

Copy link

@EgyLynx EgyLynx commented Jun 24, 2019

Are you mean these where cam at vechiles? Are youre think at game "wait" vechiles at right/Left and when one side is not possible it isnt know how continue? So there should be message tells at it not work that way...

@James103

This comment has been minimized.

Copy link
Contributor Author

@James103 James103 commented Jun 24, 2019

image

  1. Select one of the drive-through road stops, which looks like this (for buses). Note that this crash affects only the drive through road stops, not the road vehicle bays.
    image

  2. If the highlighted tile is owned by towns AND one-way, then the game will crash when building a drive through road stop there. In this case, both conditions are true.

  3. When building a drive through road stop under these conditions, the game crashes because one or more special cases weren't handled properly (in this case the special case of drive-through stop on town-owned road)

ddm999 added a commit to ddm999/OpenTTD that referenced this issue Jun 26, 2019
…cked roads owned by towns (instead of crashing).
JGRennison added a commit to JGRennison/OpenTTD-patches that referenced this issue Jul 11, 2019
@Ben79487

This comment has been minimized.

Copy link

@Ben79487 Ben79487 commented Jul 12, 2019

It's probably due to the fact that bus stops can't be one-way, therefore the game tries to build a one-way bus stop but can't.

@James103

This comment has been minimized.

Copy link
Contributor Author

@James103 James103 commented Jul 30, 2019

Still crashes in 20190723-master-g2e686ad5d5. Crash files have been attached.
Why haven't the PR fixing this crash, #7627, been merged already? It's been more than a month since the PR was opened, and 3 and a half weeks since it was approved to merge.

@LordAro

This comment has been minimized.

Copy link
Member

@LordAro LordAro commented Jul 30, 2019

Because there are some questions about the fix. I should've removed the review, tbh

@nielsmh nielsmh added this to the 1.10.0 milestone Sep 1, 2019
@nielsmh nielsmh closed this in 2d9eb1c Sep 6, 2019
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Sep 7, 2019
…cked roads owned by towns (instead of crashing).
LordAro added a commit that referenced this issue Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.