Possible overflow in landscaping rate limit handling can introduce randomness into whether landscaping succeeds #8611
Labels
needs triage
This issue needs further investigation before it becomes actionable
Version of OpenTTD
1.11.0 beta 1
Expected result
Large terraform operations should deterministically succeed or fail based on the rate limits, for which some of the variables thereof may need to be widened (16 bit --> 32 bit, 32-bit --> 64 bit)
Actual result
Large terraform operations can randomly succeed or fail when the rate limit settings are maxed out. For example, right after performing multiple large terraform operations in a row, there is an approx. 1 in 4 chance that the next terraform operation will fail completely.
Steps to reproduce
set terraform_per_64k_frames 1073741824
set terraform_frame_burst 65535
(not 65536, seeterraform_frame_burst
(and similar settings) are stored to 16-bit integers instead of 32 bits. #8610)Savegame
test-8611.zip
The text was updated successfully, but these errors were encountered: