Change: Make road & rail pathfinders account for maximum order speed, if set #8722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Buried in the text & savegame for #8594 was mention of order speed limits. The number of people who know about & use this feature is probably vanishingly small, but it seems proper that the pathfinder should take it into account when calculating the best route.
Description
Set the vehicle's max speed in the pathfinder. I could've set this in GetSpeedLimit in follow_track.hpp, but this seemed otherwise unrelated to the "track".
Order speed for road vehicles doubled because of road veh units (and that's what's done elsewhere)
Limitations
More possible changes to routing behaviour - but if you're using order speed limits, you're already doing some pretty custom stuff.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.