Fix: Apply master effect volume during mixing instead of sound start. #8945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the volume control work as most players would expect, affecting
existing playing sounds as well as new sounds.
Motivation / Problem
Changing master effect volume does not have any effect on sounds that are currently playing. It's always been this way but is pretty odd and makes setting desired volume a little harder than it needs to be.
Description
This is solved by applying the current master effect volume during the mixing process, instead of at the start of playing a sound.
Limitations
There's a slight difference of using /255 vs /256. Not sure what difference this has in practical terms.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.