Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: CMD_BUILD_ROAD_STOP changes station acceptance in estimate mode, this can cause MP desyncs #9774

Closed
JGRennison opened this issue Dec 30, 2021 · 0 comments · Fixed by #9775
Closed

[Bug]: CMD_BUILD_ROAD_STOP changes station acceptance in estimate mode, this can cause MP desyncs #9774

JGRennison opened this issue Dec 30, 2021 · 0 comments · Fixed by #9775

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

master

Expected result

No desyncs

Actual result

CmdBuildRoadStop calls Station::AfterStationTileSetChange even when DC_EXEC is not set.
Amongst other things this calls UpdateStationAcceptance.

Station::AfterStationTileSetChange should only be called when DC_EXEC is set.

Steps to reproduce

  1. Build a road stop, which accepts something
  2. Removing the houses/etc causing the acceptance
  3. Attach another road stop in estimate mode
  4. Note that acceptance changed
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Dec 30, 2021
@JGRennison
Fix OpenTTD#9774: CmdBuildRoadStop updated station acceptance in esti…
4400f4e 
…mate mode
@JGRennison JGRennison mentioned this issue Dec 30, 2021
Merged
michicc pushed a commit that referenced this issue Dec 30, 2021
@JGRennison @michicc
Fix #9774: CmdBuildRoadStop updated station acceptance in estimate mode
4844268
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Jan 3, 2022
@JGRennison @TrueBrain
Fix OpenTTD#9774: CmdBuildRoadStop updated station acceptance in esti…
c7077b5 
…mate mode
TrueBrain pushed a commit that referenced this issue Jan 5, 2022
@JGRennison @TrueBrain
Fix #9774: CmdBuildRoadStop updated station acceptance in estimate mode
e0ccc58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #9774: CmdBuildRoadStop updated station acceptance in estimate mode JGRennison/Upstream-OpenTTD
1 participant
@JGRennison