Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weirdness of new stations. #10017

Merged
merged 3 commits into from
Sep 11, 2022
Merged

Fix weirdness of new stations. #10017

merged 3 commits into from
Sep 11, 2022

Commits on Sep 10, 2022

  1. Cleanup: [NewGRF] Callback 14 used a weird value for var10 in the GUI. 

    The value 0x2110000 probably originated from a mixup between callback 14 (sprite layout) and 24 (tile layout).
The latter does indeed use a var10 value like that.
    @frosch123
    frosch123 committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    c537a67 View commit details
    Browse the repository at this point in the history

  2. Fix: [NewGRF] Result bit 0 of callback 14 was not ignored in the GUI.

    @frosch123
    frosch123 committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    7ec7043 View commit details
    Browse the repository at this point in the history

  3. Fix: [NewGRF] Ensure that stations always have an even number of spri… 

    …te layouts.

The drawing code has a special fallbacks for zero layouts, but fails hard for one layout.
(odd numbers >= 3 are weird, but do not fail as badly as 1)
    @frosch123
    frosch123 committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    d646467 View commit details
    Browse the repository at this point in the history