Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: 'string' is spurious in 'Filter string:' #10022

Merged
merged 1 commit into from Sep 12, 2022

Conversation

andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Sep 11, 2022

Motivation / Problem

  • Word 'string' is spurious in 'Filter string:' labels for filter UI widgets
  • Also related tooltips wording can be improved

People who are not programmers or linguists or mathematicians do not commonly know what 'string' is.
It's 2022, filter widgets are an established pattern in the world.

Description

  • Removed 'string' from labels for filter UI widgets
  • Also update related tooltips

Limitations

Describe here

  • Is the problem solved in all scenarios?

As far as I can find by searching src/lang/english.txt and clicking around the UI.

  • Is this feature complete? Are there things that could be added in the future?

No other translations have been touched.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

… widgets; remove it; also update related tooltips
@andythenorth
Copy link
Contributor Author

Can add screenshots if that is needed. Not sure it is 😛

@andythenorth
Copy link
Contributor Author

image

image

image

image

@frosch123 frosch123 added the preview This PR is receiving preview builds label Sep 11, 2022
@DorpsGek DorpsGek temporarily deployed to preview-pr-10022 September 11, 2022 19:22 Inactive
@LordAro LordAro merged commit 129979a into OpenTTD:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview This PR is receiving preview builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants