Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9966: workaround a VS2022 optimisation bug #10029

Merged
merged 1 commit into from Sep 13, 2022
Merged

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Sep 13, 2022

Motivation / Problem

Starting with MSVC 19.30, there is an optimisation bug silently converting a *q++ = '\r'; into q++;.
A bug report about it is still open.

Description

Applying the workaround to get our code to do what we expect.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 merged commit 57717a2 into OpenTTD:master Sep 13, 2022
@glx22 glx22 deleted the fix_9966 branch September 13, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants