Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Uninitialized variable in Income/Expence summary #10030

Closed
wants to merge 1 commit into from

Conversation

hallonsoda79
Copy link
Contributor

Motivation / Problem

While browsing in the code I found an uninitialized variable in the Income/Expence summary that could lead to wrongly calculated yearly total sum.

Description

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Could cause error in calculation of yearly total sum
@nielsmh
Copy link
Contributor

nielsmh commented Sep 13, 2022

The OverflowSafeInt type (of which Money is a specialization) has a default constructor that initializes it to 0. I don't think this is actually a bug.

@frosch123
Copy link
Member

Money is a real class, no POD integer. It has a default constructor.

@frosch123 frosch123 closed this Sep 13, 2022
@hallonsoda79 hallonsoda79 deleted the small_fix branch September 14, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants