Feature: Button to honk a vehicle's horn

[2TallTyler]

Motivation / Problem

Some transport games (Transport Fever 2, Mashinky) allow the player to honk the horn of a vehicle when riding along. Recently there was some (probably joking) discussion about adding this to OpenTTD, which apparently I took seriously. 😄

Description

Adds a horn button to train and ship windows.

Limitations

• Airplanes don't have horns, so they don't have the button
• In the original TTD sound pack, road vehicles never honk their horns. In OpenSFX they sometimes do. I chose to not include the button for road vehicles.
• Sprite suggestions or contributions welcome. 🙂

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR touches english.txt or translations? Check the guidelines
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, gs_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • newgrf_debug_data.h may need updating.
  • PR must be added to API tracker

[glx22]

Don't forget to update

OpenTTD/src/table/sprites.h

Line 57 in d0bdc13

static const uint16 OPENTTD_SPRITE_COUNT = 191;

[2TallTyler]

Accidentally drew the sprite too big. Now it's ready for review. 😄

[frosch123]

_settings_client.sound.vehicle disables vehicle sounds. A button which does nothing is weird, so either that button should somehow ignore the setting, or the setting should disable the button.

[2TallTyler]

It now plays regardless of _settings_client.sound.vehicle. That said, if the player turns the Effects volume slider all the way down as a way to disable sound effects (instead of disabling them in Settings), they won't hear the horn.

[Kuhnovic]

Haha I love the idea. It would be even better if you could send the command over the network so that you can honk to other players during multiplayer. Maybe a bit too much work though for a gimmicky feature like this, but it would be fun!

[2TallTyler]

Rebased atop #10052, which changed media/baseset/openttd.grf.

Sending horn sounds over the network sounds like an easy way to annoy other players, so I don't think I'll add that. 😃

[2TallTyler]

This is too silly a feature to justify adding a button to an already-busy UI. It would get used a few times and then just be in the way. It might be a fun hotkey-only hidden feature if anyone wants to run with it, but that person isn't me right now. 🙂

[Arastais]

That's unfortunate. Was actually looking forward to this feature 😢

[2TallTyler]

Feel free to steal my code and do what you want with it. I think a hotkey would be nice but I wouldn't use it enough to justify the time spent making a PR.